ci(release): drop stray -- when forwarding --release-as to pnpm script#96
Merged
Conversation
pnpm 7+ passes any args after a script name directly to the script, so `pnpm release -- --release-as minor` forwards the literal `--` as an argument to commit-and-tag-version, which silently ignores it and falls back to an auto bump. On pre-1.0 versions that auto bump is conservative (feat = patch), so requesting `minor` produced 0.5.0 → 0.5.1 instead of 0.6.0. Drop the `--`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Release workflow appeared to succeed but produced the wrong version:
release_type=minoron 0.5.0 yielded v0.5.1 instead of v0.6.0.pnpm 7+passes any args after a script name directly to the script — sopnpm release -- --release-as minorforwards a literal--as the first argument tocommit-and-tag-version. The tool silently ignores it and falls back to an auto bump. On a pre-1.0 version, the auto bump is conservative (treatsfeat:as patch), so the request forminorcame out as 0.5.0 → 0.5.1.Drop the
--. The "auto" branch already callspnpm releasewith no args, so this only affects the explicit-type branch.Surfaced while shipping v0.6.0 (failed run produced v0.5.1, since rolled back). With this fix, requesting
minorwill correctly runcommit-and-tag-version --release-as minorand bump to 0.6.0.Test plan
release_type=minoronce merged; verify it tagsv0.6.0.🤖 Generated with Claude Code